Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: generic: sycl: fix typos in VDISPATCH_SUM calls #2287

Merged
merged 1 commit into from
Dec 19, 2024
Merged

gpu: generic: sycl: fix typos in VDISPATCH_SUM calls #2287

merged 1 commit into from
Dec 19, 2024

Conversation

spalicki
Copy link
Contributor

This fixes the generic GPU SyCL build failing due to typos in VDISPATCH_SUM macro calls.

@spalicki spalicki self-assigned this Dec 18, 2024
@spalicki spalicki requested a review from a team as a code owner December 18, 2024 20:35
@spalicki
Copy link
Contributor Author

make test

@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Dec 18, 2024
@Rbiessy
Copy link
Contributor

Rbiessy commented Dec 19, 2024

Thanks, I was testing the exact same fix and was about to submit a PR :)

ShanoToni
ShanoToni approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ShanoToni ShanoToni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@Rbiessy
Copy link
Contributor

Rbiessy commented Dec 19, 2024

I've not found any failures in the CI pre-commit job and I believe the aarch64 errors are unrelated so merging

@Rbiessy Rbiessy merged commit 9fed40d into main Dec 19, 2024
8 of 15 checks passed
@Rbiessy Rbiessy deleted the spalicki/fix_vdispatch_sum_typos branch December 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbiessy Rbiessy Rbiessy approved these changes

@dzarukin dzarukin dzarukin approved these changes

@mgouicem mgouicem mgouicem approved these changes

@ShanoToni ShanoToni ShanoToni approved these changes

Assignees

@spalicki spalicki

Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalicki @Rbiessy @ShanoToni @mgouicem @dzarukin